Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNM - s3_bucket_info - remove call to ListBuckets when name option is specified #2184

Closed
wants to merge 1 commit into from
Closed

DNM - s3_bucket_info - remove call to ListBuckets when name option is specified #2184

wants to merge 1 commit into from

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jul 5, 2024

SUMMARY

Closes #2183

ISSUE TYPE
  • Bugfix Pull Request

@abikouo abikouo mentioned this pull request Jul 5, 2024
Open
1 task
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c1fe67f16d6b4c37bdcc21a07f7a082b

✔️ ansible-galaxy-importer SUCCESS in 4m 53s
✔️ build-ansible-collection SUCCESS in 12m 37s
✔️ ansible-test-splitter SUCCESS in 4m 52s
❌ integration-amazon.aws-1 FAILURE in 5m 51s
Skipped 43 jobs

tremble
tremble requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 from me. I can see why you might want to do this, however it's a breaking change. I guess we could make this optional, but default to fetching it...

As it stands, this results in creation_date not being returned any more, this information was coming from list_buckets

@abikouo
Copy link
Contributor Author

abikouo commented Jul 8, 2024

-1 from me. I can see why you might want to do this, however it's a breaking change. I guess we could make this optional, but default to fetching it...

As it stands, this results in creation_date not being returned any more, this information was coming from list_buckets

This is one reason I was not convinced of doing this.

@abikouo abikouo closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_s3_bucket_info needs ListBuckets permission even if a bucket name is given.
2 participants
@abikouo @tremble